Package updates#181
Conversation
Updated several of the packages Removed node-sass and chalk dependencies swapped i18next fs backend WIP: Need to fix an issue with the debug console button not triggering (remote)
latest electron package doesn't care about 'enableRemoteModule: true' anymore, remote variable was undefined.
removed hardcoded ssl, uses http and socket.io updated and replaced packages popups don't work api calls all are WIP
removed incompatible packages switching from bootstrap to balm ui for vue3 support multiselects need to be replaced with @vueform/multiselect or the balm-ui menus readline swapped to linebyline different i18n setup & package removing password strength meter, could reimplement with zxcvbn manually later Started migrating the component files to the vue3 composition api <script setup> format. This still needs to be applied to a dozen+ files. Pop ups still need work, they inherit an abstract component which will be converted into vue lib functions instead of an inherited component for composition api use. be aware this commit won't build, it's a partial dev commit to avoid loss of progression.
Pop-ups are next
Webpack changes Package updates & removing 2 multiselect packages in favour of palm-ui's select component. Switch to using mitt package to replace the eventbus emit/on messaging, as vue3 doesn't support this feature directly. Perhaps this could be replaced entirely by using ipcrenderer/ipcmain? Looking into refactoring the pop ups to use an additional modal browserview. Runs with errors, development use only.
Changing tooltip mechanism preparing modal window for prompts removed queue for alerts, one at a time migrated more of the components
Nearing implementation of modal prompts, setting modal window title and passing args through query-strings
replacing this.$* with direct import references
Next step is to ipcrender call the modals, rather than enter via $refs.popup.show & ipcrender on accept/reject.
Nearly complete popup migration, still need to verify the usage of the whitelist checkbox mechanism & whether we're calling the ipcrenderer correctly to close after _accept||_reject.
Show system notification on 'notify' now.
Removing logic from component {{ var }} sections as per vue3.
Injecting emitter properly in components.
The beetframe was visually glitching, so it was removed. You can easily move the app around, you can trigger a hidden menu via the ALT button, and trigger dev tools from the view menu. Unfortunately it no longer closes to the task tray, WIP!
adding german trying to change language from the hidden menu
Almost complete the cloud account auth route, ran into bitsharesjs issue #92
Added node connection selection to step 1 of the add account wizard Adding next/back buttons to the import method components Removing 'set' functions Debugging network connection issues & initial node config choices
removed invalid nodes added node dropdown props fixing settingsstore issues
Using develop branch of bitsharesjs to get around crypto bug Developing the dashboard, account select, balance and account detail components. Small changes to setting store mutators.
Trying to load modals on link request Fixing css font loading errors Removing unnecessary component
Added modal.js back Moving logic to beetserver away from components
Client now waits for modal response properly
Remove console logs
|
It is now displaying properly on my Laptop, nothing cut out anymore! Signing a message is now also working properly. What is the purpose of the Signature Verification dialog? |
|
The sign message example script immediately attempts to verify the signed message, by verifying the signed message it proves that the signed message was valid. The prompt requests permission to perform the verification, perhaps the info could be conveyed better in the prompt? I could have made it a separate script, but then would have needed to save the output of the signMessage script for input in the verifyMessage script. After looking more into the mkcert option for https, I've decided to reintroduce part of the old https method, to improve compatibility. Will update the beet-js to detect if https or http is up & commit once working. |
That's an unnecessary double check for the user. No single one will actually validate that signature by hand since you just created it. You can of course validate the signature directly after creating it, but asking the user to OK that is breaking UX. User must trust Beet to sign properly. |
|
Alright, I'll make the message verification automatic without user prompt. |
Remove prompt for message verification. Reintroduce git fetched https w/ http fallback.
Was previously signing null instead of the payload text
Revert to running both https and http servers again Introduce signNFT JSON prompt function
Required prior to issuing an NFT, as nft_object data requires signature
|
Message verification prompt is gone now. I feel like this is ready for merge at this point :) |
Added progress indication for the dashboard balance and the bitshares cloud password login.
Padding, margins, making the prompt contents more readable
Improve health checks for BTS wss connections
If node connection fails during balance lookup, temp ban it so we switch nodes.
bug fix
User supplied data is now properly encoded/decoded when launching a prompt.
When a bitshares user attempts to inject a create_asset or update_asset command, a prompt will now be shown in beet. Still needs final callback debuging however these tx types broadcast through beet now.
Filter accounts based on requested chain Properly return result from apuUtils.
|
There are some UX issues and other minor issues to be worked out, but general flow works. |
|
Beetlejuice Beetlejuice Beetlejuice Interested in skimming this PR a bit? |
|
Summary of changes in PR:
Security changes
UI changes
New functionality
Maintenance based decisions
|
Thanks. Copied to OP. |
abitmore
left a comment
There was a problem hiding this comment.
Removed cert stored in repo, fetches cert from beet cert repo
Where is the "beet cert repo"?
|
… On Fri, 5 Aug 2022, 08:05 Abit, ***@***.***> wrote:
***@***.**** commented on this pull request.
Removed cert stored in repo, fetches cert from beet cert repo
Where is the "beet cert repo"?
—
Reply to this email directly, view it on GitHub
<#181 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADZAOF2VFHXSNG4QPVWUD73VXS4LRANCNFSM5UGJDQJQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Thanks. Looks like the certs aren't getting updated automatically. If it's a Let's encrypt cert, since it points to By the way, we'd better use a repo in the bitshares organization. |
|
Want to create such a bts cert repo? Or shall such a change be introduced in a future pull request? |
|
This is a monster, lets do with new PR |
Tracker for development by @grctest.
(The following is copied from #181 (comment))
Summary of changes in PR:
Security changes
secp from "@noble/secp256k1"and @noble/ed25519 for key exchangeUI changes
New functionality
Maintenance based decisions