Skip to content

Update functional.py#992

Merged
Titus-von-Koeller merged 2 commits intobitsandbytes-foundation:mainfrom
sxndqc:main
Jan 28, 2024
Merged

Update functional.py#992
Titus-von-Koeller merged 2 commits intobitsandbytes-foundation:mainfrom
sxndqc:main

Conversation

@sxndqc
Copy link
Copy Markdown
Contributor

@sxndqc sxndqc commented Jan 27, 2024

Update type indicator

@Titus-von-Koeller Titus-von-Koeller merged commit 8ddfda1 into bitsandbytes-foundation:main Jan 28, 2024
@Titus-von-Koeller
Copy link
Copy Markdown
Collaborator

Good catch! Thanks for your contribution, really appreciated.

@akx
Copy link
Copy Markdown
Contributor

akx commented Jan 29, 2024

This isn't a valid type annotation, though 😅

bitsandbytes/functional.py:893: error: Syntax error in type annotation  [syntax]
bitsandbytes/functional.py:893: note: Suggestion: Use Tuple[T1, ..., Tn] instead of (T1, ..., Tn)

(See #994)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants