Skip to content

Fix typehint error#859

Merged
TimDettmers merged 1 commit intomainfrom
younesbelkada-patch-1
Nov 8, 2023
Merged

Fix typehint error#859
TimDettmers merged 1 commit intomainfrom
younesbelkada-patch-1

Conversation

@younesbelkada
Copy link
Copy Markdown
Collaborator

@younesbelkada younesbelkada commented Nov 8, 2023 •
edited
Loading

The recent 0.41.2 version causes some errors when one tries to install bitsandbytes

    class QuantState:
  File "/usr/local/lib/python3.8/site-packages/bitsandbytes/functional.py", line 603, in QuantState
    def from_dict(cls, qs_dict: dict[str, Any], device: torch.device) -> 'QuantState':
TypeError: 'type' object is not subscriptable

This PR fixes it - would be great to add this PR in a patch release if possible 🙏

cc @TimDettmers @poedator @Titus-von-Koeller

@younesbelkada younesbelkada mentioned this pull request Nov 8, 2023
Merged
@TimDettmers
Copy link
Copy Markdown
Collaborator

TimDettmers commented Nov 8, 2023

Thank you for being so quick on this!

@TimDettmers TimDettmers merged commit f1ef74f into main Nov 8, 2023
@Titus-von-Koeller Titus-von-Koeller deleted the younesbelkada-patch-1 branch December 13, 2023 09:50
@younesbelkada younesbelkada mentioned this pull request Feb 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TimDettmers TimDettmers Awaiting requested review from TimDettmers

@Titus-von-Koeller Titus-von-Koeller Awaiting requested review from Titus-von-Koeller

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@younesbelkada @TimDettmers