Skip to content

8BitAdamW and bitsandbytes.functional.create_dynamic_map#262

Closed
ArrowM wants to merge 1 commit intobitsandbytes-foundation:mainfrom
ArrowM:main
Closed

8BitAdamW and bitsandbytes.functional.create_dynamic_map#262
ArrowM wants to merge 1 commit intobitsandbytes-foundation:mainfrom
ArrowM:main

Conversation

@ArrowM
Copy link
Copy Markdown

@ArrowM ArrowM commented Apr 7, 2023

Address Issue #227

Hello! 8BitAdamW has stopped working for Dreambooth since 0.36.0 (loss NaNs very quickly). I took a stab at reviewing the differences between the releases. The if-block around functional.py:218 in 2f2063b may have been accidentally indented. tests.test_functional.test_few_bit_quant doesn't cover the inside of the if block, so maybe this was missed (or it was intentional and it'd be great to have confirmation). I'm hoping one of the maintainers can take a quick look. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant