Hi @Titus-von-Koeller Could you please review? Thanks. Looks like the CI failure is about ROCM. I am not sure if the failure is caused by this PR.

Related: pytorch/pytorch#124245

I'm not sure what PyTorch release that's going to land in, but good news is that it looks like it'll eventually support MSVC on Windows and we can update this as appropriate. Until then, I think this will be OK.

https://github.com/pytorch/pytorch/blob/main/torch/_inductor/cpp_builder.py#L123-L134 @Xia-Weiwen FYI.

Hi @matthewdouglas Yes, it will still take some time to enable torch.compile on Windows, and the clang compiler is required. The contributor is @xuhancn . So, I would agree that it's better to disable it on Windows now and enable it later when everything is ready.

Hi @matthewdouglas Yes, it will still take some time to enable torch.compile on Windows, and the clang compiler is required. The contributor is @xuhancn . So, I would agree that it's better to disable it on Windows now and enable it later when everything is ready.

Windows default compiler is msvc(cl.exe), please correct it. :)

Hi @matthewdouglas Yes, it will still take some time to enable torch.compile on Windows, and the clang compiler is required. The contributor is @xuhancn . So, I would agree that it's better to disable it on Windows now and enable it later when everything is ready.

Windows default compiler is msvc(cl.exe), please correct it. :)

Thanks for the correction.

Hi @matthewdouglas Yes, it will still take some time to enable torch.compile on Windows, and the clang compiler is required. The contributor is @xuhancn . So, I would agree that it's better to disable it on Windows now and enable it later when everything is ready.

Windows default compiler is msvc(cl.exe), please correct it. :)

Thanks for the correction.

@Xia-Weiwen does this still need correction or is this ready to merge? In the diff it still shows gcc for the compiler...

@Titus-von-Koeller That's just a correction on comment about the compiler requirement for Windows (when we get there). It will use MSVC by default and not clang. I think it's OK to merge now as it is and my commentary here is just a note for future refinement.

Hi @Titus-von-Koeller . This PR does not need correction. torch.compile is not ready on Windows yet. G++ is required for torch.compile now. So, this PR just disable it on Windows by checking if G++ is available. @matthewdouglas is correct. Thanks.

Hi @Titus-von-Koeller Do you have more comments? Thanks

Hallo @Titus-von-Koeller It's been a while since last update. Do you think there are any blocking issues preventing this PR merging? Thanks.

@Xia-Weiwen Yes, everything is right the way it is then, thanks for the clarification!

@Xia-Weiwen Yes, everything is right the way it is then, thanks for the clarification!

Thanks!