provide temp flag for outside libs to detect multi-backend preview#1243
Merged
Titus-von-Koeller merged 2 commits intobitsandbytes-foundation:multi-backend-refactorfrom Jun 21, 2024
Conversation
Co-authored-by: Benjamin Bossan <BenjaminBossan@users.noreply.github.com>
akx
reviewed
Jun 6, 2024
Comment on lines
+23
to
+28
| # NOTE: this is a temporary flag to allow outside libraries to employ conditional logic while the refactor is still in | ||
| # alpha/beta: sth like `if getattr(bitsandbytes, "is_multi_backend_refactor_preview", False): do sth` | ||
| # the getattr() call above would default to False and any string evaluates to True. This way we have temporary thing | ||
| # that we can remove in Transformers with the next release after the official BNB multi-platform release; then | ||
| # eventually making it the new default (e.g. just remove if statement and dedent in Transformers) | ||
| is_multi_backend_refactor_preview = "TO BE REMOVED ONCE MERGED TO `main`" # bool evals to True for str |
Contributor
There was a problem hiding this comment.
If we wanted to make this a more permanent feature (and I don't see why not), it could just be e.g. features = {"multi_backend"}...
c79b1e9
into
bitsandbytes-foundation:multi-backend-refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After internal discussion how to handle this Transformers issue that came up when trying to test the alpha release in conjunction with the HF ecosystem, this is a simple approach that could help outside libs detect if they're dealing with the BNB preview version.
Wdyt @younesbelkada @akx @matthewdouglas ?
Hmm, maybe setting it to True is cleaner.. Thought of the
strbefore adding the extensive comment..Added this snippet to
bnb/__init__.py: