Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an integer overflow issue in the bitset library on 32-bit architectures by reducing a test index value and adding a CI workflow to test on 32-bit systems.
- Reduced test index from 6346235235 to 63235235 to avoid overflow on 32-bit systems
- Added GitHub Actions workflow for testing on 386 architecture
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| bitset_test.go | Reduces test index value to prevent overflow on 32-bit systems |
| .github/workflows/legacy86.go | Adds CI workflow for testing on 386 architecture |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+8
to
+16
| - name: Install Go | ||
| uses: actions/setup-go@v5 | ||
| with: | ||
| go-version: ${{ matrix.go-version }} | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
| - name: Test on 386 | ||
| run: | | ||
| GOARCH=386 go test No newline at end of file |
There was a problem hiding this comment.
The workflow is missing the 'steps:' keyword before the step definitions, and the 'strategy.matrix' configuration for the go-version variable referenced on line 11. The workflow should include 'steps:' at line 7 and a strategy matrix defining go-version values.
Suggested change
| - name: Install Go | |
| uses: actions/setup-go@v5 | |
| with: | |
| go-version: ${{ matrix.go-version }} | |
| - name: Checkout code | |
| uses: actions/checkout@v4 | |
| - name: Test on 386 | |
| run: | | |
| GOARCH=386 go test | |
| strategy: | |
| matrix: | |
| go-version: [ '1.20.x', '1.21.x' ] | |
| steps: | |
| - name: Install Go | |
| uses: actions/setup-go@v5 | |
| with: | |
| go-version: ${{ matrix.go-version }} | |
| - name: Checkout code | |
| uses: actions/checkout@v4 | |
| - name: Test on 386 | |
| run: | | |
| GOARCH=386 go test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #209