Fix Response crash when API response lacks time node#407
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… responses (#343) Signed-off-by: mesilov <mesilov.maxim@gmail.com>
…ll documentation (#NNN) Signed-off-by: mesilov <mesilov.maxim@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some Bitrix24 API endpoints (e.g.
documentation/v3) return a response without atimenode.The existing workaround set
timeto an empty array and then calledTime::initFromResponse([]),which triggered PHP errors on undefined array keys (
$response['start'], etc.).This fix adds
Time::initWithZeroValues()— a static factory that fills all numeric fields with0.0and both date fields withCarbonImmutable::now().Response::getResponseData()now callsthis factory instead of
Time::initFromResponse([])whenever thetimenode is absent or empty.Test plan
make lint-cs-fixer— passedmake lint-rector— passedmake lint-phpstan— passedmake lint-deptrac— passedmake test-unit— passed (665 tests, 1151 assertions)Closes #343
🤖 Generated with Claude Code