Add oauthServerUrl field to LocalAppAuth#405
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LocalAppAuthstores authentication data for local apps. When a Bitrix24 event or placement requestarrives, the raw auth payload contains
server_endpoint— the OAuth server URL that issued the token(e.g.
oauth.bitrix24.techfor east,oauth.bitrix.infofor west).Previously
LocalAppAuthdid not store this URL, so any consumer reconstructingCredentialsfrom a saved
LocalAppAuthhad to hard-code or guess the OAuth server viaDefaultOAuthServerUrl::default(),which breaks multi-region deployments.
Changes:
oauthServerUrl: stringconstructor parameter toLocalAppAuthgetOAuthServerUrl(): stringgettertoArray()serialises it asoauth_server_urlinitFromArray()readsoauth_server_urlwith a fallback toDefaultOAuthServerUrl::default()for backward compatibility with files written by older SDK versionsTest plan
make lint-cs-fixer— passedmake lint-rector— passed (auto-fix applied: variable rename by Rector)make lint-phpstan— passedmake lint-deptrac— passed (0 violations)make test-unit— passed (661 tests, 1136 assertions)Closes #385
🤖 Generated with Claude Code