[bitnami/elasticsearch] Enable probess + add support for custom ones#6691
Merged
Conversation
Signed-off-by: juan131 <juanariza@vmware.com>
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: juan131 juanariza@vmware.com
Description of the change
Incomprehensibly, the Elasticsearch chart doesn't enable readiness/liveness probes by default in the values.yaml (although the README.md states the opposite). We should enable them since it's a key functionality to avoid K8s to allow traffic to the pods before they're ready and provide K8s a way to detect sth isn't going well when the health-checks are failing.
The PR also adds support for other common parameters we have in other charts: the "customXXXProbe" so users can define their own probes.
Benefits
Possible drawbacks
None
Applicable issues
N/A
Additional information
N/A
Checklist
Chart.yamlaccording to semver.