[bitnami/elasticsearch] Use 3 master nodes by default#6587
Conversation
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files |
|
Hi, |
|
Hi, @rafariossaa . Did your test uncover any issues with the PR? Can I be of any help to test this PR? I could contribute a helm test so we could atomate some parts of testing. Something similart to this https://github.com/elastic/helm-charts/blob/master/elasticsearch/templates/test/test-elasticsearch-health.yaml maybe? |
|
Hi, @yariksheptykin |
|
Hi, |
|
No problem @rafariossaa . I rebased the patch onto the latest upstream master. The version was set to However one might argue that changing default values in |
|
Hi, |
Description of the change
Currently, when using default settings, we install 2 master nodes. This PR suggests using 3 nodes by default to address "split brain" situation by default. "Split brain" occurs when a cluster elects more than one master due to network partitioning. See https://www.elastic.co/guide/en/elasticsearch/reference/7.x/modules-discovery-quorums.html#modules-discovery-quorums
Elasticsearch documentation suggests using an even number of master nodes to address this issue https://www.elastic.co/guide/en/elasticsearch/reference/7.x/modules-discovery-voting.html#_even_numbers_of_master_eligible_nodes. The next reasonable odd number for the default settings would be 3.
Benefits
Address "split brain" issue by default.
Possible drawbacks