[bitnami/zookeeper] Add support for autogenerated certs#6532
Merged
Conversation
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files |
juan131
requested changes
Jun 3, 2021
juan131
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR! Please check my comments
juan131
requested changes
Jun 16, 2021
Comment on lines
+290
to
+321
| image: | ||
| registry: docker.io | ||
| repository: bitnami/zookeeper | ||
| tag: 3.7.0-debian-10-r56 | ||
| ## Specify a imagePullPolicy | ||
| ## Defaults to 'Always' if image tag is 'latest', else set to 'IfNotPresent' | ||
| ## ref: http://kubernetes.io/docs/user-guide/images/#pre-pulling-images | ||
| ## | ||
| pullPolicy: IfNotPresent | ||
| ## Optionally specify an array of imagePullSecrets. | ||
| ## Secrets must be manually created in the namespace. | ||
| ## ref: https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/ | ||
| ## | ||
| # pullSecrets: | ||
| # - myRegistryKeySecretName | ||
| ## Init containers' resource requests and limits | ||
| ## ref: http://kubernetes.io/docs/user-guide/compute-resources/ | ||
| ## | ||
| resources: | ||
| ## We usually recommend not to specify default resources and to leave this as a conscious | ||
| ## choice for the user. This also increases chances charts run on environments with little | ||
| ## resources, such as Minikube. If you do want to specify resources, uncomment the following | ||
| ## lines, adjust them as necessary, and remove the curly braces after 'resources:'. | ||
| ## | ||
| limits: {} | ||
| ## cpu: 100m | ||
| ## memory: 128Mi | ||
| ## | ||
| requests: {} | ||
| ## cpu: 100m | ||
| ## memory: 128Mi | ||
| ## |
Contributor
There was a problem hiding this comment.
I will use the image.* values and remove this
Contributor
|
Please fix the conflicts, and don't forget to update the pipeline to include the new image |
Contributor
|
Please fix the conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Adds support for autoGenerated certificates to the bitnami/zookeeper chart.
Possible drawbacks
None known.
Checklist
Chart.yamlaccording to semver.