Skip to content

[bitnami/redis-cluster] Added support to generate custom certificate for redis#14323

Closed
navneet066 wants to merge 9 commits into
bitnami:mainfrom
navneet066:master
Closed

[bitnami/redis-cluster] Added support to generate custom certificate for redis#14323
navneet066 wants to merge 9 commits into
bitnami:mainfrom
navneet066:master

Conversation

@navneet066

@navneet066 navneet066 commented Jan 12, 2023

Copy link
Copy Markdown
Contributor

Description of the change

Added support to generate the custom certificate for the redis-cluster.

Benefits

Earlier: If we need to use the custom CA, We needed to create the kubernetes secret beforehand and fill the values.yaml accordingly.

Now: In this change, If we pass the base64 value of the CA and KEY in values.yaml, It will generate the Kubernetes secret accordingly for the redis-cluster.

Possible drawbacks

None known so far, previous behaviour can still be applied

Applicable issues

  • Right now there is no issue associated with it. It is like a enhancement for the chart

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

navneet066 and others added 7 commits January 12, 2023 23:54
Signed-off-by: navneet066 <navneet.nandan@widas.in>
Signed-off-by: navneet066 <navneet.nandan@widas.in>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: navneet066 <navneet.nandan@widas.in>
Signed-off-by: navneet066 <navneet.nandan@widas.in>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: navneet066 <navneet.nandan@widas.in>
Signed-off-by: navneet066 <navneet.nandan@widas.in>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: navneet066 <navneet.nandan@widas.in>
@carrodher carrodher added the verify Execute verification workflow for these changes label Jan 13, 2023
@bitnami-bot bitnami-bot removed the request for review from carrodher January 13, 2023 07:32
@github-actions github-actions Bot added in-progress and removed triage Triage is needed labels Jan 13, 2023
@bitnami-bot bitnami-bot requested a review from corico44 January 13, 2023 07:32
@corico44

Copy link
Copy Markdown
Contributor

Hello @navneet066, could you provide me how you have tested these changes to reproduce it, please?

@github-actions

Copy link
Copy Markdown

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions Bot added the stale 15 days without activity label Jan 29, 2023
Signed-off-by: corico44 <42420333+corico44@users.noreply.github.com>
@github-actions github-actions Bot removed the stale 15 days without activity label Jan 31, 2023
@corico44

Copy link
Copy Markdown
Contributor

@navneet066 Could you please resolve the conflicts in the tls-secrets.yaml file, please?

@corico44

Copy link
Copy Markdown
Contributor

@navneet066 ping!

Could you please resolve the conflicts in the tls-secrets.yaml file so we can close this PR, please?

@github-actions

github-actions Bot commented Mar 3, 2023

Copy link
Copy Markdown

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions Bot added the stale 15 days without activity label Mar 3, 2023
@corico44 corico44 removed the stale 15 days without activity label Mar 6, 2023
@github-actions

Copy link
Copy Markdown

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions Bot added the stale 15 days without activity label Mar 22, 2023
@github-actions

Copy link
Copy Markdown

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary.

@bitnami-bot bitnami-bot added stale 15 days without activity and removed stale 15 days without activity labels Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

redis-cluster solved stale 15 days without activity verify Execute verification workflow for these changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants