Support winston 3.x transports and formats#190
Merged
crellison merged 1 commit intobithavoc:masterfrom Oct 3, 2018
Merged
Conversation
In their 3.0.0 release, winston deprecated formatting inside transports. This PR adds formats to the options passed into the express-winston logger and errorLogger.
|
How's the call for maintainers coming along? Would be great to see this merged |
Owner
|
@crellison feel free to merge and let me know when you'd like me to publish. |
Collaborator
Author
|
@bithavoc Time to give the people what they want |
Owner
|
@crellison can you update the changelog in another PR or commit to master? |
Collaborator
Author
|
Yup! I'll do that tonight |
Owner
|
Once we do that we can merge and Release. good call @rosston |
Collaborator
Author
|
changelog updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In their 3.0.0 release, winston deprecated formatting inside transports.
https://github.com/winstonjs/winston/blob/master/UPGRADE-3.0.md#removed-winstontransportsfileconsolehttp-formatting-options
This PR adds formats to the options passed into the express-winston logger
and errorLogger.
This package also needs a fresh release of typings to DefinitelyTyped, as it's latest version is not compatible with the current winston release.