Merged
Conversation
Collaborator
|
@CryptArchy Sorry, only just now looking at this. Thanks for contributing (with tests)! This all looks good to me. If you could just update the docs to mention the function usage of |
Add documentation
d3564ee to
0a5075a
Compare
Contributor
Author
|
@rosston Thanks for the review! I totally forgot about updating the documentation, but I got you covered now! Let me know if anything else needs to be adjusted. |
Collaborator
|
Perfect. Your clarifying comment on Released in 2.4.0. Thank you @CryptArchy! |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow
options.levelto be a function for dynamic level setting.A project I am working on requires the ability to dynamically set the log level based on deeper inspection of the request and response. I added unit tests based on the existing ones, and everything is passing. I tried to set sane defaults and checks that should preserve the existing behavior of the middleware with
options.levelset to a string or object. Only setting it to a function should behave differently, and that wasn't a valid option before.