Cargo.toml: Anchor excludes to root of the package#387
Merged
KodrAus merged 1 commit intobitflags:mainfrom Dec 11, 2023
Merged
Conversation
Without anchoring the excludes, src/tests/ is missing from the published crate. This causes “cargo test” to fail because code referenced by src/tests.rs is not present.
Member
|
Thanks @jamessan! This looks good to me. The CI failure is unrelated; I'm fixing that up in a separate PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without anchoring the excludes, src/tests/ is missing from the published
crate. This causes “cargo test” to fail because code referenced by
src/tests.rs is not present.
This is important for distributors, like Debian, who build their
packages from the crate rather than the VCS. Our own CI is currently
failing for bitflags due to this. We can disable the tests for now, but
it would be helpful to be able to run them.