Add a hidden trait to discourage manual impls of BitFlags#261
Merged
Conversation
|
That makes a lot of sense yeah. |
konsumlamm
reviewed
Oct 23, 2021
Co-authored-by: konsumlamm <44230978+konsumlamm@users.noreply.github.com>
Co-authored-by: konsumlamm <44230978+konsumlamm@users.noreply.github.com>
Member
Author
|
Thanks @konsumlamm and @arturoc! This should be ready for another look now. |
Contributor
|
I expected this to be an error after #261 (comment), but it still compiles (because of the |
Member
Author
|
Alrighty, I’ll merge this one in and we can follow up with some more bits and pieces. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #220
cc @konsumlamm @arturoc
This adds a hidden supertrait to our new
BitFlagstrait that suggests you shouldn't implement it manually. Since we only supportBitFlagsthrough thebitflags!macro it means we could safely add new methods and supertraits (likeAddand friends) toBitFlagswithout breaking consumers.I've also just been adding to our test suite wherever I can too so there are some other new tests added there too.