run clippy in compile-pass tests if available

KodrAus · KodrAus · commit 60ef5ee91485 · 2023-10-09T14:45:14.000+10:00
diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml
@@ -114,6 +114,9 @@ jobs:
           cd ./tests/smoke-test
           cargo +beta clippy
 
+      - name: Tests
+        run: cargo test
+
   embedded:
     name: Build (embedded)
     runs-on: ubuntu-latest
diff --git a/src/lib.rs b/src/lib.rs
@@ -481,7 +481,8 @@ macro_rules! bitflags {
             non_upper_case_globals,
             clippy::assign_op_pattern,
             clippy::indexing_slicing,
-            clippy::same_name_method
+            clippy::same_name_method,
+            clippy::iter_without_into_iter,
         )]
         const _: () = {
             // Declared in a "hidden" scope that can't be reached directly
@@ -553,7 +554,8 @@ macro_rules! bitflags {
             unused_mut,
             unused_imports,
             non_upper_case_globals,
-            clippy::assign_op_pattern
+            clippy::assign_op_pattern,
+            clippy::iter_without_into_iter,
         )]
         const _: () = {
             __impl_public_bitflags! {
diff --git a/tests/compile-pass/item_positions.rs b/tests/compile-pass/item_positions.rs
@@ -1,3 +1,5 @@
+#![allow(clippy::let_unit_value)]
+
 #[macro_use]
 extern crate bitflags;
 
diff --git a/tests/compile-pass/missing_docs.rs b/tests/compile-pass/missing_docs.rs
@@ -0,0 +1,19 @@
+/*!
+Crate-level doc
+*/
+
+#![deny(missing_docs)]
+
+use bitflags::bitflags;
+
+bitflags! {
+    #[allow(missing_docs)]
+    pub struct MyFlags: u32 {
+        #[allow(missing_docs)]
+        const A = 1;
+        #[allow(missing_docs)]
+        const B = 2;
+    }
+}
+
+fn main() {}
diff --git a/tests/compile-pass/pedantic.rs b/tests/compile-pass/pedantic.rs
@@ -0,0 +1,12 @@
+#![deny(clippy::pedantic)]
+
+use bitflags::bitflags;
+
+bitflags! {
+    pub struct MyFlags: u32 {
+        const A = 1;
+        const B = 2;
+    }
+}
+
+fn main() {}
diff --git a/tests/compile.rs b/tests/compile.rs
@@ -11,6 +11,13 @@ fn fail() {
 
 #[test]
 fn pass() {
+    // If `clippy` is available, then use it
+    if std::process::Command::new("clippy-driver").arg("--version").output().is_ok() {
+        println!("Using `clippy`");
+
+        std::env::set_var("RUSTC_WORKSPACE_WRAPPER", "clippy-driver");
+    }
+
     let t = trybuild::TestCases::new();
     t.pass("tests/compile-pass/**/*.rs");
 }

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+#![allow(clippy::let_unit_value)]`
	`2`	`+`
`1`	`3`	`#[macro_use]`
`2`	`4`	`extern crate bitflags;`
`3`	`5`