Conversation
brunoerg
left a comment
There was a problem hiding this comment.
What's the relation between rust-bitcoin and rust-psbt? Just wondering if rust-psbt is used in rust-bitcoin.
|
Needs to format: cd rust_psbt_lib && cargo fmt --check
Diff in /home/runner/work/bitcoinfuzz/bitcoinfuzz/modules/rustpsbt/rust_psbt_lib/src/lib.rs:69:
Err(_) => std::ptr::null_mut(),
}
}
+
make[1]: *** [Makefile:33: check-format] Error 1 |
They are very similar. I noticed that they use some types from rust-bitcoin, but the deserialize method and the struct PSBT are implemented in the rust-psbt crate. They plan to migrate the PSBT from the rust-bitcoin to rust-psbt. rust-bitcoin/rust-bitcoin#5697 cc @tcharding |
84f20d6 to
c2c4729
Compare
|
Btw, this is basically a copy and paste from the lib.rs from rust-bitcoin implementation for the psbt_parse harness. I plan to refactor the parse_psbt target in a follow-up pull request (PR) by adding all the fields that a PSBT can have. |
c2c4729 to
3ca3e2e
Compare
|
|
closes: #419