Skip to content

feat: add rust-psbt module#444

Merged
brunoerg merged 1 commit intobitcoinfuzz:v2from
erickcestari:rust-psbt
Feb 23, 2026
Merged

feat: add rust-psbt module#444
brunoerg merged 1 commit intobitcoinfuzz:v2from
erickcestari:rust-psbt

Conversation

@erickcestari
Copy link
Copy Markdown
Member

@erickcestari erickcestari commented Feb 21, 2026

closes: #419

Copy link
Copy Markdown
Collaborator

@brunoerg brunoerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the relation between rust-bitcoin and rust-psbt? Just wondering if rust-psbt is used in rust-bitcoin.

@brunoerg
Copy link
Copy Markdown
Collaborator

Needs to format:

cd rust_psbt_lib && cargo fmt --check
Diff in /home/runner/work/bitcoinfuzz/bitcoinfuzz/modules/rustpsbt/rust_psbt_lib/src/lib.rs:69:
         Err(_) => std::ptr::null_mut(),
     }
 }
+
make[1]: *** [Makefile:33: check-format] Error 1

@erickcestari
Copy link
Copy Markdown
Member Author

What's the relation between rust-bitcoin and rust-psbt? Just wondering if rust-psbt is used in rust-bitcoin.

They are very similar. I noticed that they use some types from rust-bitcoin, but the deserialize method and the struct PSBT are implemented in the rust-psbt crate. They plan to migrate the PSBT from the rust-bitcoin to rust-psbt.

rust-bitcoin/rust-bitcoin#5697

cc @tcharding

@erickcestari erickcestari force-pushed the rust-psbt branch 2 times, most recently from 84f20d6 to c2c4729 Compare February 21, 2026 19:51
@erickcestari
Copy link
Copy Markdown
Member Author

Btw, this is basically a copy and paste from the lib.rs from rust-bitcoin implementation for the psbt_parse harness. I plan to refactor the parse_psbt target in a follow-up pull request (PR) by adding all the fields that a PSBT can have.

@tcharding
Copy link
Copy Markdown

rust-psbt code was pulled out of rust-bitcoin 0.32 a while back and then development stalled. It has now picked back up with the plan being to remove the psbt code out of rust-bitcoin 0.33 all together. I think fuzzing both bitcoin 0.32 and psbt would be super useful in case we make mistakes migrating the code. Thanks a bunch.

Copy link
Copy Markdown
Collaborator

@brunoerg brunoerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 3ca3e2e

@brunoerg brunoerg merged commit 2d2995d into bitcoinfuzz:v2 Feb 23, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add module rust-psbt

3 participants