Skip to content

Upgrade bitcoin#60

Closed
tcharding wants to merge 1 commit intobitcoindevkit:masterfrom
tcharding:10-16-upgrade-bitcoin
Closed

Upgrade bitcoin#60
tcharding wants to merge 1 commit intobitcoindevkit:masterfrom
tcharding:10-16-upgrade-bitcoin

Conversation

@tcharding
Copy link
Copy Markdown
Contributor

@tcharding tcharding commented Oct 16, 2023 •
edited
Loading

Upgrade dependencies to use the latest rust-bitcoin v0.31.

While we are at it, bump the crate version ready for release.

@tcharding tcharding force-pushed the 10-16-upgrade-bitcoin branch from 8c52614 to 397e459 Compare December 11, 2023 23:42
@tcharding
Copy link
Copy Markdown
Contributor Author

tcharding commented Dec 11, 2023

Needs rust-electrum-client release as well as electrsd.

@notmandatory notmandatory mentioned this pull request Dec 13, 2023
Closed
@notmandatory
Copy link
Copy Markdown
Member

notmandatory commented Dec 20, 2023

Needs rust-electrum-client release as well as electrsd.

new electrum-client 0.19 is ready to go: https://crates.io/crates/electrum-client/0.19.0

@tcharding tcharding force-pushed the 10-16-upgrade-bitcoin branch from 397e459 to f03e950 Compare December 21, 2023 21:22
@tcharding
Copy link
Copy Markdown
Contributor Author

tcharding commented Dec 21, 2023 •
edited
Loading

Needs electrsd release still: RCasatta/electrsd#74

@tcharding tcharding force-pushed the 10-16-upgrade-bitcoin branch from f03e950 to 7a980cc Compare December 23, 2023 02:03
@tcharding tcharding marked this pull request as ready for review December 23, 2023 02:04
@tcharding
Copy link
Copy Markdown
Contributor Author

tcharding commented Dec 23, 2023 •
edited
Loading

I think the pinning problems are unrelated to this PR, leaving that for someone else.

cargo test --all-features --all-targets runs cleanly locally on this branch.

@notmandatory notmandatory added this to the Release 0.7.0 milestone Dec 29, 2023
@notmandatory
Copy link
Copy Markdown
Member

notmandatory commented Dec 29, 2023

I made #69 to bump our MSRV to 1.63 and fix the CI issues.

@tcharding tcharding force-pushed the 10-16-upgrade-bitcoin branch 2 times, most recently from fcdec65 to 80218a4 Compare January 5, 2024 22:02
@tcharding
Copy link
Copy Markdown
Contributor Author

tcharding commented Jan 5, 2024

The test_get_height fail needs investigating, will come back to this.

@tcharding
Copy link
Copy Markdown
Contributor Author

tcharding commented Jan 7, 2024 •
edited
Loading

The test_get_height test passes locally for me and the RawFd error seems unrelated to this PR.

@tcharding
Upgrade bitcoin
e53ba34 
Upgrade dependencies to use the latest `rust-bitcoin v0.31`.

While we are at it, bump the crate version ready for release.
@tcharding tcharding force-pushed the 10-16-upgrade-bitcoin branch from 80218a4 to e53ba34 Compare January 7, 2024 23:37
@tcharding
Copy link
Copy Markdown
Contributor Author

tcharding commented Jan 7, 2024

No changes, just kicking CI.

@getong getong mentioned this pull request Jan 27, 2024
Closed
@getong
Copy link
Copy Markdown

getong commented Jan 27, 2024

It looks good. Still working for it?

@getong getong mentioned this pull request Jan 27, 2024
Closed
@getong
Copy link
Copy Markdown

getong commented Jan 27, 2024

I open #74 , which fix the ci error.
The ci result can be seen here
getong#1

@getong getong mentioned this pull request Jan 27, 2024
Closed
5 tasks
@tcharding
Copy link
Copy Markdown
Contributor Author

tcharding commented Jan 29, 2024

I'm happy for you to take over, closing in favour of #74. Thanks

@tcharding tcharding closed this Jan 29, 2024
This was referenced Feb 7, 2024
Closed
Merged
@notmandatory notmandatory removed this from the Release 0.7.0 milestone Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@tcharding tcharding

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tcharding @notmandatory @getong