Skip to content

feat(client): add get_block_infos and deprecate get_blocks#164

Merged
oleonardolima merged 4 commits intobitcoindevkit:release/0.12.xfrom
luisschwab:chore/deprecate-get-blocks
Jan 29, 2026
Merged

feat(client): add get_block_infos and deprecate get_blocks#164
oleonardolima merged 4 commits intobitcoindevkit:release/0.12.xfrom
luisschwab:chore/deprecate-get-blocks

Conversation

@luisschwab
Copy link
Copy Markdown
Member

@luisschwab luisschwab commented Jan 24, 2026 •
edited
Loading

Changelog

  • Add get_block_infos
  • Deprecate get_blocks

Also pins socket2@0.6.2 to v0.5.10 and fixes the CI badge link.

@luisschwab luisschwab changed the title feat: add get_block_infos and deprecate get_blocks feat(client): add get_block_infos and deprecate get_blocks Jan 24, 2026
@coveralls
Copy link
Copy Markdown

coveralls commented Jan 24, 2026 •
edited
Loading

Pull Request Test Coverage Report for Build 21366757407

Details

  • 44 of 46 (95.65%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 86.951%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/async.rs 9 10 90.0%
src/blocking.rs 9 10 90.0%
Totals Coverage Status
Change from base Build 21307540618: 0.2%
Covered Lines: 1446
Relevant Lines: 1663
💛 - Coveralls

@luisschwab luisschwab force-pushed the chore/deprecate-get-blocks branch from 809b65b to b20c67d Compare January 24, 2026 19:46
@luisschwab luisschwab force-pushed the chore/deprecate-get-blocks branch from 8c5849c to 183f1d1 Compare January 24, 2026 20:40
oleonardolima
oleonardolima reviewed Jan 26, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 183f1d1

@luisschwab luisschwab force-pushed the chore/deprecate-get-blocks branch from 183f1d1 to 67ef0cf Compare January 26, 2026 17:00
@oleonardolima
Copy link
Copy Markdown
Collaborator

oleonardolima commented Jan 26, 2026

@luisschwab I think you've left some trailing whitespaces there, fmt is failing.

@luisschwab luisschwab force-pushed the chore/deprecate-get-blocks branch from 67ef0cf to 3500b24 Compare January 26, 2026 17:10
@luisschwab
Copy link
Copy Markdown
Member Author

luisschwab commented Jan 26, 2026

@oleonardolima fixed

@oleonardolima oleonardolima added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 26, 2026
@oleonardolima oleonardolima moved this to Needs Review in BDK Chain Jan 26, 2026
oleonardolima
oleonardolima approved these changes Jan 26, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 3500b24

notmandatory
notmandatory approved these changes Jan 28, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 3500b24

@notmandatory
Copy link
Copy Markdown
Member

notmandatory commented Jan 28, 2026

Has get_blocks just been broken all this time or did something else change?

@luisschwab
Copy link
Copy Markdown
Member Author

luisschwab commented Jan 28, 2026

We were just omitting information, unless the Esplora API spec changed between when this was implemented and now.

@oleonardolima oleonardolima merged commit 2e3e8b2 into bitcoindevkit:release/0.12.x Jan 29, 2026
26 checks passed
@github-project-automation github-project-automation bot moved this from Needs Review to Done in BDK Chain Jan 29, 2026
@luisschwab luisschwab deleted the chore/deprecate-get-blocks branch January 29, 2026 22:05
@oleonardolima oleonardolima mentioned this pull request Jan 31, 2026
Closed
3 tasks
@luisschwab luisschwab mentioned this pull request Feb 20, 2026
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@notmandatory notmandatory notmandatory approved these changes

@oleonardolima oleonardolima oleonardolima approved these changes

@ValuedMammal ValuedMammal Awaiting requested review from ValuedMammal

Assignees

@luisschwab luisschwab

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

BDK Chain
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@luisschwab @coveralls @oleonardolima @notmandatory