Closed
Conversation
✅ Deploy Preview for awesome-golick-685c88 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Aside from the custom properties add filter for date formatting and helper methods for sorting meeting pages according to the most recent.
929a831 to
4cbc1fd
Compare
4cbc1fd to
2a504d0
Compare
Member
danielabrozzoni
left a comment
There was a problem hiding this comment.
Heads up, there are some CSS issues
|
|
||
| At the top of that file. Add the following frontmatter content | ||
|
|
||
| ``` |
Member
There was a problem hiding this comment.
Is this supposed to be empty?
Contributor
Author
There was a problem hiding this comment.
No, I will fix that.
26 tasks
|
I am willing to help maintain this if we ever implement :) |
Member
|
Closing this now as we're not quite ready to host a PR review club on a steady basis. Feel free to reopen when it's a good time! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ports the Bitcoin Core review site to a section on our BDK website.
I maintained the styling from the Bitcoin Core review site instead of going with our own website theme.
I also maintained IRC as the meeting location.
I think the website is ready to be used, at least for our next meeting. There are still some nits that can be improved upon like having multiple navs on the meetings page as the bitcoin core website page.
These will be worked on future PRs.
I have kind of messed up the navigation, currently working on fixing it.