deps!: update bdk_chain to 0.22.0#208
Merged
notmandatory merged 4 commits intobitcoindevkit:masterfrom May 8, 2025
Merged
Conversation
Pull Request Test Coverage Report for Build 14905703496Details
💛 - Coveralls |
Member
|
Why is this part of the 1.3 milestone and not 2.0? |
evanlinjin
reviewed
Apr 15, 2025
Member
|
I renamed the old milestones so had to put this one back on the new 2.0. |
2fceda8 to
a60d70d
Compare
bdk at revision b7075865bdk at revision 4fe121e7
bdk at revision 4fe121e7bdk_chain to 4fe121e7
c83afda to
c2d27c0
Compare
`once_cell` remains pinned to 1.20.3
c2d27c0 to
a247215
Compare
bdk_chain to 4fe121e7bdk_chain to 0.22.0
Collaborator
Author
|
I added a commit to expose the
I think this could be done in a follow up PR. |
evanlinjin
reviewed
May 8, 2025
Member
evanlinjin
left a comment
There was a problem hiding this comment.
Looks good, just a small nit.
Also, I think we could also include eviction logic in example_wallet_rpc. I've done so in 4a52074
3c5fa0b to
e125014
Compare
Collaborator
Author
|
Thanks @evanlinjin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
bdk_chaindependency to the latest version 0.22.0Notes to the reviewers
This PR doesn't make use of
CanonicalizationParamsfor any advanced use cases - instead we rely on the default params for all tx-graph queries.fixes #202
fixes #224
Changelog notice
bdk_chainto 0.22.0bdk_file_storeto 0.20.0Added
start_sync_with_revealed_spks_atstart_full_scan_atapply_evicted_txsChanged
start_sync_with_revealed_spksis feature gated by "std", as it uses the system time to provide the time of the sync and also the tx last-seen.apply_updateno longer requires std, as the timestamp is provided in the sync / full scan requeststart_full_scanis also gated behind "std"start_sync_*now includes the expected SPK history (vialist_expected_spk_txids)Removed
apply_update_atBREAKING
bdk_core::TxUpdateis non-exhaustive Make full-scan/sync flow easier to reason about. bdk#1838FileStoreErroris changed to hold a new inner type Refactor file store bdk#1684Changes to persisted data
The
tx_graph::ChangeSetgained a new default-able fieldlast_evictedto persist the fact that a tx is no longer part of the canonical chain.Checklists
All Submissions:
cargo fmtandcargo clippybefore committing