-
Notifications
You must be signed in to change notification settings - Fork 71
additional information for sign, finalize_psbt when returning false #73
Copy link
Copy link
Open
Labels
good first issueGood for newcomersGood for newcomersnew featureNew feature or requestNew feature or request
Milestone
Description
Describe the enhancement
I'm wondering if anyone has potentially thought of any alternatives to the return type than what currently exists for sign Result<bool, SignerError>
Use case
I'm specifically thinking about a client app signing a transaction and getting bool of false back without additional information of why sign returned false.
Maybe they were expecting it to return false but maybe not; that client app may expect successful signing, not receive true or SignerError back, but get back false instead without extra context, on what could be considered an imporant operation for their app.
Additional context
Just looking for feedback/thoughts if there has been conversation about this historically/presently, and any possible thoughts.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomersnew featureNew feature or requestNew feature or request
Type
Projects
Status
Discussion