This is my proposal (as mentioned in bitcoindevkit/bdk#1272 (comment)):

I think we should have a file chain/types.rs that contains all smaller public traits and structs (replacing chain_data.rs and tx_data_traits.rs files). Balance should be in types.rs.

Also I have removed the first good issue tag and added the discussion tab as the discussion is not final, and I don't want anyone else to give us a PR (we already have two: bitcoindevkit/bdk#1272 and bitcoindevkit/bdk#1175).

Update:

After reading @LLFourn's comment here (bitcoindevkit/bdk#1272 (comment)):

It would be great to avoid a types.rs. This is totally unhelpful name because everything we declare is a type. It's fine to put things in lib.rs if there's no where else it belongs.

It would be fine to put tx_data_traits.rs into chain_data.rs. I don't recall why tx_data_traits.rs was created.

I agree with this - to merge tx_data_traits.rs into chain_data.rs. I think Balance should also go in chain_data.rs.

Merge tx_data_traits.rs into chain_data.rs. #128

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Merge `tx_data_traits.rs` into `chain_data.rs`. #128