Closed
Conversation
Member
Author
|
@bodymindarts would you be able to test this branch against your large test descriptor? |
Member
Author
|
I fixed a few spelling typos to trigger a new build. Not sure why github wouldn't run the actions pipeline initially. |
Member
Author
|
Looks like some tests in CI are failing, I'll work on fixing those. |
Contributor
|
Just for clarification. It has > 200k addresses. About half and half from the public and the change descriptor. I'm not sure how many transactions but same order-of-magnitude. I will try it out as soon as possible! |
This was referenced May 23, 2023
b94f673 to
aed44be
Compare
16 tasks
aed44be to
ce517a5
Compare
ce517a5 to
7967a9d
Compare
8 tasks
Member
Author
|
Removed from 0.29 milestone and closing this PR since issues are already fixed in 1.0 syncing mechanism. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
Wallet.ensure_addresses_cached()function was always regenerating and saving new scripts pubkeys starting from index 0. This is inefficient and for very large wallets and can cause sync to fail.Notes to the reviewers
This issue was discovered by @bodymindarts while testing on a 200K+ transaction wallet.
Since this is more of a performance issue than functional/scaling problem I only added a test to verify that with multiple cached batches created during sync, the transaction to addresses in each cached batch are found. An integration test syncing 200K+ tx would take too long to complete.
Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingBugfixes: