Introduce new bdk_coin_select implementation#924
Closed
LLFourn wants to merge 8 commits intobitcoindevkit:masterfrom
Closed
Introduce new bdk_coin_select implementation#924LLFourn wants to merge 8 commits intobitcoindevkit:masterfrom
bdk_coin_select implementation#924LLFourn wants to merge 8 commits intobitcoindevkit:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is porting over LLFourn/bdk_core_staging#46
I made it compile on 1.48.0 and added a script that we can use in CI to check that all the crates that should be able to compile on 1.48.0 can.
TODO:
I've had a request to do a release of the separately before it is used in
bdkitself so that other projects can try it out.cc @darosior