Closed
Conversation
462d2e5 to
88386ef
Compare
- ChainGraph::determine_relevant_changeset - KeychainTracker::determine_relevant_changeset, KeychainTracker::determine_additions, KeychainTracker::apply_update_relevant, - TxGraph::determine_relevant_additions
88386ef to
f8043bc
Compare
Member
|
@danielabrozzoni does this PR need to be rebase/worked now that that #976 is merge? |
Member
Author
|
I'm really not sure, @evanlinjin is this PR still needed? |
Member
It definitely needs further discussion. It depends if everyone is happy with my approach in #1041, or do we feel that having an |
26 tasks
Collaborator
I think having |
30 tasks
Member
Author
|
Closing as the approach changed radically anyways |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #903
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features: