Conversation
|
Concept looks good, please rebase to fix the CI error. |
rajarshimaitra
left a comment
There was a problem hiding this comment.
Concept ACK, thanks for the example.. I think its more useful to demo how to run tor from the code.. But good to see that its actually working.. I have funded the wallet address with some coins so hopefully the full example will work again..
Below are few general comments..
rajarshimaitra
left a comment
There was a problem hiding this comment.
Needs few more changes.. And can you please squash the commits and rebase on master?
|
I'm sorry, I'm not a Git power user. I don't feel comfortable with interactive rebase. I always use GitHub's "Squash And Merge". It really does wonders, IMHO. |
Probably a good time google on those and get those basics done as they are rudimentary to contributing to open source projects.. You don't need interactive rebase.. |
Probably. Nobody complained about me not being a git power user for many years of contributing to open source projects, though. I'd rather keep using automation... |
|
@rorp this needs a rebase on master. With esplora_client updated now this configuration #816 (comment) should work. |
|
@rorp we're getting an error with In the meantime I'm going to have to remove this from 0.27 milestone. See also: https://github.com/bitcoindevkit/bdk/actions/runs/3895859305/jobs/6739813321 |
|
This should be ready to go after @rajarshimaitra's final review. I'll rebase/squash the commits for the original author. |
rajarshimaitra
left a comment
There was a problem hiding this comment.
ReACK d4b3f56
Needs a rebase and its good to go..
|
Thanks for all your work on this but we've gotten to the point where I'd like to hold off on merging any new features and only merge critical bug fixes to the Can you rebase this after the new |
|
Hey, can you please rebase this one on master? |
|
@danielabrozzoni Done! |
| "crates/bdk", | ||
| "crates/chain", | ||
| "crates/file_store", | ||
| "crates/electrum", | ||
| "example-crates/keychain_tracker_electrum", | ||
| "example-crates/keychain_tracker_esplora", | ||
| "example-crates/keychain_tracker_example_cli", | ||
| "example-crates/wallet_electrum", | ||
| "example-crates/wallet_esplora", | ||
| "example-crates/wallet_esplora_async", | ||
| "example-crates/wallet_esplora_tor", | ||
| "nursery/tmp_plan", | ||
| "nursery/coin_select" | ||
| ] | ||
|
|
||
| default-members = [ |
There was a problem hiding this comment.
Why do we need both members and default-members?
There was a problem hiding this comment.
To prevent example-crates/wallet_esplora_tor to be built by default. It depends on libtor, which requires a C compiler, but BDK as a library doesn't and most important it shouldn't.
In this configuration one can build BDK without installing the additional dependencies simply by running
cargo buildAnd after installing the additional dependencies one can build this example with
cargo build -p bdk-esplora-wallet-tor-exampleI agree, this is not the most elegant solution, so I'm open for suggestions how to improve it.
|
I'll open a new PR that covers Tor support relying on Is there any active development on this one? cc @rorp @notmandatory Otherwise, I can reuse the example of |
|
@oleonardolima I'll close this one so you can do a new PR based on the arti-client. |
Description
A self contained example that demonstrates using a TOR proxy with the Esplora blockchain client.
Blog post PR bitcoindevkit/bitcoindevkit.org#134
Fixes bitcoindevkit/bdk_wallet#196
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: