Test: No address reuse for single descriptor#661
Merged
danielabrozzoni merged 1 commit intobitcoindevkit:masterfrom Jul 20, 2022
Merged
Conversation
This test is to ensure there are no regressions when we later change internal logic of `Wallet`. A single descriptor wallet should always get a new address with `AddressIndex::New` even if we alternate grabbing internal/external keychains.
rajarshimaitra
approved these changes
Jul 12, 2022
Contributor
rajarshimaitra
left a comment
There was a problem hiding this comment.
tACK 2c02a44
LGTM..
Member
|
tACK 2c02a44 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Just a simple new test.
This test is to ensure there are no regressions when we later change
internal logic of
Wallet. A single descriptor wallet should always geta new address with
AddressIndex::Neweven if we alternate grabbinginternal/external keychains.
I thought of adding this during work on #647
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing