ci: pin rustls for msrv#1802
Merged
ValuedMammal merged 1 commit intobitcoindevkit:masterfrom Jan 16, 2025
Merged
Conversation
Collaborator
Author
|
Hm, not sure if merging is blocked because this didn't run on rust 1.83. If so, I can revert the last commit. *Made a typo - |
rustls to 0.23.21 + fix clippy nits + bump rust-version to 1.84rustls + fix clippy nits + bump rust-version to 1.84
8cd344a to
5b4bf19
Compare
Contributor
|
Hmm, I'm not sure if pinning Please also see the discussion here, would love to get some more feedback: #1750 |
5b4bf19 to
e4cf5b5
Compare
rustls + fix clippy nits + bump rust-version to 1.84rustls for msrv
Collaborator
Author
|
@oleonardolima I had to drop the commit to update rust-version, so I guess we can address it on #1801 |
Collaborator
Author
|
Pinning rustls should be considered a temporary fix while we continue to hash out #1750 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the current CI issue by pinning
rustlsagain to 0.23.19