Skip to content

test(wallet): small cleanups to test_wallet_transactions_relevant#1785

Merged
ValuedMammal merged 1 commit intobitcoindevkit:masterfrom
notmandatory:fix/wallet-transactions-test
Dec 23, 2024
Merged

test(wallet): small cleanups to test_wallet_transactions_relevant#1785
ValuedMammal merged 1 commit intobitcoindevkit:masterfrom
notmandatory:fix/wallet-transactions-test

Conversation

@notmandatory
Copy link
Copy Markdown
Member

@notmandatory notmandatory commented Dec 20, 2024

Description

This cleans up the test_wallet_transactions_relevant test based on suggestions that didn't make it into #1779.

Notes to the reviewers

Also included a small use cleanup in wallet/mod.

Changelog notice

None.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@luisschwab
Copy link
Copy Markdown
Member

ACK 6346536

Copy link
Copy Markdown
Collaborator

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 6346536

@ValuedMammal ValuedMammal merged commit a208144 into bitcoindevkit:master Dec 23, 2024
@notmandatory notmandatory deleted the fix/wallet-transactions-test branch December 23, 2024 14:28
@ValuedMammal ValuedMammal mentioned this pull request Feb 4, 2025
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants