Skip to content

fix: typos#1599

Merged
notmandatory merged 1 commit intobitcoindevkit:masterfrom
storopoli:fix-more-typos
Sep 11, 2024
Merged

fix: typos#1599
notmandatory merged 1 commit intobitcoindevkit:masterfrom
storopoli:fix-more-typos

Conversation

@storopoli
Copy link
Copy Markdown

@storopoli storopoli commented Sep 10, 2024

Description

more typos caught up during rebasing of #1320.

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@storopoli storopoli mentioned this pull request Sep 10, 2024
Closed
8 tasks
oleonardolima
oleonardolima approved these changes Sep 10, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK bc83e41

@LagginTimes
Copy link
Copy Markdown
Contributor

LagginTimes commented Sep 11, 2024

ACK bc83e41

thunderbiscuit
thunderbiscuit approved these changes Sep 11, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK bc83e41.

@notmandatory notmandatory added the documentation Improvements or additions to documentation label Sep 11, 2024
@notmandatory notmandatory added this to the 1.0.0-beta milestone Sep 11, 2024
@notmandatory notmandatory merged commit 532f906 into bitcoindevkit:master Sep 11, 2024
@storopoli storopoli deleted the fix-more-typos branch September 11, 2024 16:57
This was referenced Sep 13, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oleonardolima oleonardolima oleonardolima approved these changes

@thunderbiscuit thunderbiscuit thunderbiscuit approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

BDK Wallet
Archived in project

Milestone

1.0.0-beta

Development

Successfully merging this pull request may close these issues.

5 participants

@storopoli @LagginTimes @oleonardolima @thunderbiscuit @notmandatory