refactor(wallet): use Amount everywhere#1595
Merged
notmandatory merged 1 commit intobitcoindevkit:masterfrom Sep 9, 2024
Merged
refactor(wallet): use Amount everywhere#1595notmandatory merged 1 commit intobitcoindevkit:masterfrom
Amount everywhere#1595notmandatory merged 1 commit intobitcoindevkit:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup to #1426 that refactors wallet internals to use
bitcoin::Amount(nearly) everywhere. I chose not to change any public types incoin_selection.rsthat still useu64as that might require more discussion.partially addresses #1432
fixes #1434
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing