Skip to content

ci: add cron-update-rust.yml#1564

Merged
notmandatory merged 1 commit intobitcoindevkit:masterfrom
ValuedMammal:ci/clippy
Aug 23, 2024
Merged

ci: add cron-update-rust.yml#1564
notmandatory merged 1 commit intobitcoindevkit:masterfrom
ValuedMammal:ci/clippy

Conversation

@ValuedMammal
Copy link
Copy Markdown
Collaborator

@ValuedMammal ValuedMammal commented Aug 21, 2024

This adds a cronjob to watch for updates to rust stable once a month. If the latest version changed, then a pull request is opened to see if clippy passes CI using the new toolchain.

Notes to the reviewers

Let me know what you think @notmandatory

fixes #1431

Changelog notice

Checklists

TODO

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

Copy link
Copy Markdown
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I just have one small comment.

Copy link
Copy Markdown

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good exactly what we do in rust-bitcoin.
You got the idea! Really nice to see what we've discussed briefly in the summit being implemented.

Just need to set the token stuff in the repo/org and then we are good to go to merge it.

@ValuedMammal ValuedMammal force-pushed the ci/clippy branch 2 times, most recently from bd73b93 to e5a9751 Compare August 22, 2024 13:25
@ValuedMammal ValuedMammal marked this pull request as ready for review August 22, 2024 13:44
@notmandatory notmandatory added this to the 1.0.0-beta milestone Aug 22, 2024
Copy link
Copy Markdown
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e5a9751

@ValuedMammal if you need more permission to create secrets.MY_TOKEN let me know.

Copy link
Copy Markdown
Collaborator

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e5a9751

@ValuedMammal
Copy link
Copy Markdown
Collaborator Author

ACK e5a9751

@ValuedMammal if you need more permission to create secrets.MY_TOKEN let me know.

As far as I can tell I'm not able to add secrets to the repo

Copy link
Copy Markdown
Collaborator

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK b92f8c9

I don't think you'll need any further secrets.GITHUB_TOKEN changes, I tested it in my forked repository and it worked just fine.

I manually triggered the workflow and it automatically created a new PR as expected.

@notmandatory notmandatory merged commit 9e6ac72 into bitcoindevkit:master Aug 23, 2024
@notmandatory notmandatory mentioned this pull request Aug 25, 2024
31 tasks
@ValuedMammal ValuedMammal deleted the ci/clippy branch August 30, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Create nightly job to bump clippy rust version

4 participants