Skip to content

fix(example_cli): add bitcoin and rand dependencies#1549

Merged
notmandatory merged 2 commits intobitcoindevkit:masterfrom
notmandatory:fix/chain_example_cli
Aug 14, 2024
Merged

fix(example_cli): add bitcoin and rand dependencies#1549
notmandatory merged 2 commits intobitcoindevkit:masterfrom
notmandatory:fix/chain_example_cli

Conversation

@notmandatory
Copy link
Copy Markdown
Member

@notmandatory notmandatory commented Aug 12, 2024

Description

Fix building example_cli by adding the bitcoin and rand dependencies so it, and the crates that depend on it, can be built independently and not only from the workspace.

Notes to the reviewers

I also added the build-examples CI job to verify we can build examples individually.

Changelog notice

None.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants