Skip to content

example: Update example_cli and retire old nursery crates#1495

Merged
evanlinjin merged 1 commit intobitcoindevkit:masterfrom
ValuedMammal:example/cli
Aug 12, 2024
Merged

example: Update example_cli and retire old nursery crates#1495
evanlinjin merged 1 commit intobitcoindevkit:masterfrom
ValuedMammal:example/cli

Conversation

@ValuedMammal
Copy link
Copy Markdown
Collaborator

@ValuedMammal ValuedMammal commented Jul 1, 2024 •
edited
Loading

  • Adds two commands init and generate. Loading database doesn't require descriptors
  • Replaces send command with psbt (new, sign, and extract). Supports tap key spend
  • Uses bdk-coin-select and miniscript plan module

fixes #1469
partially addresses #1462

Notes to the reviewers

Note the example_cli lib now defines the ChangeSet and Anchor type whereas before these were generic

Changelog notice

  • Improvements to example_cli that include generating descriptors and creating PSBTs

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@storopoli
Copy link
Copy Markdown

storopoli commented Jul 1, 2024

We could merge this with #1442 and then commit it as a single PR?

If favorable I could rebase #1442 and then you can commit on top of that? Or I can do the opposite as well...

@ValuedMammal
Copy link
Copy Markdown
Collaborator Author

ValuedMammal commented Jul 1, 2024

1442 can be merged anytime and from what I can tell doesn't conflict with this one

@nondiremanuel nondiremanuel added this to the 1.0.0-beta milestone Jul 2, 2024
@rustaceanrob
Copy link
Copy Markdown
Contributor

rustaceanrob commented Jul 11, 2024

Nice. This cleans things up quite a bit.

@ValuedMammal ValuedMammal marked this pull request as ready for review July 12, 2024 16:15
@ValuedMammal
Copy link
Copy Markdown
Collaborator Author

ValuedMammal commented Jul 24, 2024

  • Rebased onto 17a9850
  • For now I'm using bdk_wallet::ChangeSet for the example-cli
  • Added back support for single descriptor use
  • CI failed to build msrv

LLFourn
LLFourn reviewed Jul 25, 2024
View reviewed changes
LLFourn
LLFourn reviewed Jul 25, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@LLFourn LLFourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ConceptACK this looks great.

@ValuedMammal ValuedMammal force-pushed the example/cli branch 2 times, most recently from a889259 to 382d07b Compare July 28, 2024 15:32
@nymius nymius mentioned this pull request Jul 28, 2024
Closed
5 tasks
@ValuedMammal ValuedMammal changed the title Upgrade example_cli example: Update example_cli and retire old nursery crates Aug 4, 2024
evanlinjin
evanlinjin approved these changes Aug 11, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 771f6b9

A lot better than what we had before. Made the examples a lot more useful.

@evanlinjin evanlinjin merged commit 98c4959 into bitcoindevkit:master Aug 12, 2024
@ValuedMammal
Copy link
Copy Markdown
Collaborator Author

ValuedMammal commented Aug 12, 2024

Thanks @evanlinjin @LLFourn

We're currently limited to creating PSBTs for wpkh and tr descriptors because I got stuck on trying to add assets/keys for wsh (can still sync and derive addresses though).

@evanlinjin
Copy link
Copy Markdown
Member

evanlinjin commented Aug 12, 2024

@ValuedMammal I think that's fine for now, can add them later

@ValuedMammal ValuedMammal deleted the example/cli branch August 12, 2024 13:01
@notmandatory notmandatory mentioned this pull request Aug 25, 2024
Closed
31 tasks
@ValuedMammal ValuedMammal mentioned this pull request Sep 19, 2024
Closed
@ValuedMammal ValuedMammal mentioned this pull request Feb 2, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LLFourn LLFourn LLFourn left review comments

@evanlinjin evanlinjin evanlinjin approved these changes

Assignees

@ValuedMammal ValuedMammal

Labels

None yet

Projects

BDK Wallet
Archived in project

Milestone

1.0.0-beta

Development

Successfully merging this pull request may close these issues.

Remove nursery/tmp_plan

6 participants

@ValuedMammal @storopoli @rustaceanrob @evanlinjin @LLFourn @nondiremanuel