fix: typo on SignedAmount instead of Amount#1458
Merged
notmandatory merged 1 commit intobitcoindevkit:masterfrom Jun 14, 2024
Merged
fix: typo on SignedAmount instead of Amount#1458notmandatory merged 1 commit intobitcoindevkit:masterfrom
SignedAmount instead of Amount#1458notmandatory merged 1 commit intobitcoindevkit:masterfrom
Conversation
5 tasks
storopoli
approved these changes
Jun 5, 2024
Collaborator
Author
|
@notmandatory I think this would need to land in 1.0.0-alpha.13 as well, as it fixes the typo introduced by #1426 |
notmandatory
approved these changes
Jun 14, 2024
Member
notmandatory
left a comment
There was a problem hiding this comment.
ACK 20341a3
@oleonardolima I'll make sure this one is in the alpha.13 release too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It fixes the typo on the
expect()message introduced on #1426, noticed at #1426 (comment)Checklists
All Submissions:
cargo fmtandcargo clippybefore committing