Skip to content

ci: Pin clippy to rust 1.78.0#1430

Merged
notmandatory merged 1 commit intobitcoindevkit:masterfrom
ValuedMammal:ci/clippy
May 9, 2024
Merged

ci: Pin clippy to rust 1.78.0#1430
notmandatory merged 1 commit intobitcoindevkit:masterfrom
ValuedMammal:ci/clippy

Conversation

@ValuedMammal
Copy link
Copy Markdown
Collaborator

This PR pins clippy check in CI to the rust 1.78 toolchain, which prevents new lints in stable releases from interrupting the usual workflow. Because rust versions are released on a predictable schedule, we can revisit this setting in the future as needed (say 3-6 months).

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@ValuedMammal ValuedMammal added the ci label May 7, 2024
Comment thread .github/workflows/cont_integration.yml
Copy link
Copy Markdown
Member

@danielabrozzoni danielabrozzoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK de2763a

Copy link
Copy Markdown

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK de2763a

@apoelstra
Copy link
Copy Markdown

In rust-bitcoin we have started pinning our nightly compiler (which is where we run clippy) and we have a cronjob that runs every so often (was daily, but we reduced it to twice a week, and realistically it'd be fine if it were twice a year) which opens a PR to bump the pin.

If the PR passes CI we know that we can accept it and increase our pin. If it fails CI then we can see that there's an upcoming lint failure and we can address it at our own pace.

Copy link
Copy Markdown
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK de2763a

Copy link
Copy Markdown
Collaborator

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK de2763a

@notmandatory notmandatory merged commit 86408b9 into bitcoindevkit:master May 9, 2024
@danielabrozzoni
Copy link
Copy Markdown
Member

In rust-bitcoin we have started pinning our nightly compiler (which is where we run clippy) and we have a cronjob that runs every so often (was daily, but we reduced it to twice a week, and realistically it'd be fine if it were twice a year) which opens a PR to bump the pin.

@apoelstra thanks for sharing! Definitely something we should do in the future, we did forget to bump the pin on CI a few times. Opened a new good first issue: #1433

@ValuedMammal ValuedMammal deleted the ci/clippy branch May 9, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants