Skip to content

chore: typos#1319

Merged
notmandatory merged 1 commit intobitcoindevkit:masterfrom
storopoli:js/typos
Feb 4, 2024
Merged

chore: typos#1319
notmandatory merged 1 commit intobitcoindevkit:masterfrom
storopoli:js/typos

Conversation

@storopoli
Copy link
Copy Markdown

@storopoli storopoli commented Feb 4, 2024 •
edited
Loading

More caught on by Nix CI in #1257.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

chore: typos
8d93fad 
More caught on by Nix CI in bitcoindevkit#1257.
evanlinjin
evanlinjin approved these changes Feb 4, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8d93fad

@storopoli storopoli mentioned this pull request Feb 4, 2024
Closed
8 tasks
@notmandatory notmandatory added this to the 1.0.0 milestone Feb 4, 2024
notmandatory
notmandatory approved these changes Feb 4, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8d93fad

@notmandatory notmandatory merged commit d8f74dc into bitcoindevkit:master Feb 4, 2024
@storopoli storopoli deleted the js/typos branch February 4, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@notmandatory notmandatory notmandatory approved these changes

@evanlinjin evanlinjin evanlinjin approved these changes

Assignees

@storopoli storopoli

Labels

None yet

Projects

BDK Wallet
Archived in project

Milestone

1.0.0-alpha

Development

Successfully merging this pull request may close these issues.

3 participants

@storopoli @notmandatory @evanlinjin