Bump bip39 dependency to v2.0#1259
Merged
notmandatory merged 1 commit intobitcoindevkit:masterfrom Jan 7, 2024
Merged
Conversation
We previously bumped the `bip39` version to 2.0 in the 0.2X release branch. Back then, bumping it in `master` was erroneously considered unnecessary. Here, we therefore bump the crate version in `master` after all.
Contributor
Author
|
@notmandatory Any chance this could still make it in to 1.0-alpha.3? |
Member
|
Thanks for catching this. I'll make sure it's in the alpha.3 release. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We previously bumped the
bip39version to 2.0 in the 0.2X release branch. Back then, bumping it inmasterwas assumed unnecessary. It seems this was erroneous, as the current1.0.1dependency is present since #793, which was merged before the bump inrelease/0.27.Here, we therefore bump the crate version in
masterafter all.