Skip to content

Refactor/rename electrum_ext and esplora_ext to have sync and full_scan functions#1235

Merged
notmandatory merged 2 commits intobitcoindevkit:masterfrom
notmandatory:refactor/rename_scan_functions
Jan 6, 2024
Merged

Refactor/rename electrum_ext and esplora_ext to have sync and full_scan functions#1235
notmandatory merged 2 commits intobitcoindevkit:masterfrom
notmandatory:refactor/rename_scan_functions

Conversation

@notmandatory
Copy link
Copy Markdown
Member

@notmandatory notmandatory commented Dec 7, 2023

Description

fixes #1112

Simple function renaming plus updated docs:

  1. electrum_ext: rename functions scan_without_keychain to sync and scan to full_scan
  2. esplora_ext: rename functions scan_txs to sync and scan_txs_with_keychains to full_scan

Notes to the reviewers

The esplora_ext changes were partially fixed in #1070 but I renamed again so the functions match names suggested in #1112 agreed on in discord poll, sync and full_scan.

Changelog notice

Changed

  • electrum_ext: rename functions scan_without_keychain to sync and scan to full_scan
  • esplora_ext: rename functions scan_txs to sync and scan_txs_with_keychains to full_scan

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

scan_without_keychain and scan's names should be inverted

3 participants