Refactor/rename electrum_ext and esplora_ext to have sync and full_scan functions#1235
Merged
notmandatory merged 2 commits intobitcoindevkit:masterfrom Jan 6, 2024
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixes #1112
Simple function renaming plus updated docs:
scan_without_keychaintosyncandscantofull_scanscan_txstosyncandscan_txs_with_keychainstofull_scanNotes to the reviewers
The esplora_ext changes were partially fixed in #1070 but I renamed again so the functions match names
suggested in #1112agreed on in discord poll,syncandfull_scan.Changelog notice
Changed
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing