Skip to content

chore: fix MSRV for flate2#1182

Merged
evanlinjin merged 2 commits intobitcoindevkit:masterfrom
evanlinjin:fix_msrv_flate2
Nov 6, 2023
Merged

chore: fix MSRV for flate2#1182
evanlinjin merged 2 commits intobitcoindevkit:masterfrom
evanlinjin:fix_msrv_flate2

Conversation

@evanlinjin
Copy link
Copy Markdown
Member

No description provided.

@evanlinjin
Copy link
Copy Markdown
Member Author

It's still broken, will revisit later (unless if someone would like to take over).

@realeinherjar
Copy link
Copy Markdown
Contributor

I think that rustls:0.21.7 needs to be changed to rustls:0.21.8

@notmandatory
Copy link
Copy Markdown
Member

This is ready to re-review and merge. I don't want to have a broken CI holding up merging other PRs while we wait to figure out if it's OK to bump our MSRV with #1183.

@notmandatory
Copy link
Copy Markdown
Member

I had to downgrade hashbrown since I can't even do a cargo update otherwise. It looks like the 0.10 and 0.11 versions are pointing to yanked versions of ahash.

Copy link
Copy Markdown
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 95250fc

Copy link
Copy Markdown
Contributor

@realeinherjar realeinherjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 95250fc

Copy link
Copy Markdown
Member Author

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 95250fc

@evanlinjin evanlinjin merged commit 2f2f138 into bitcoindevkit:master Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants