Update rust bitcoin (BDK 0.28)#1071
Merged
notmandatory merged 4 commits intobitcoindevkit:release/0.28from Aug 16, 2023
Merged
Conversation
576be45 to
9e0f8b8
Compare
Member
Author
|
CBF is broken but I'm too tired to look into it right now 😅 |
Member
|
FYI in the past couple days some dependencies broke for 1.57.0 MSRV, I'm fixing it in #1074 . |
42b6ca3 to
68b4233
Compare
5d6ee0e to
af5dd7c
Compare
Member
notmandatory
left a comment
There was a problem hiding this comment.
LGTM! I just have one suggestion and a question.
26 tasks
Although there is *some* code to handle multipath keys inside bdk, it's all untested, and from a few quick tests it seems that it's pretty easy to find buggy edge cases. Better to deny multipath descs for now, and revisit the decision once we work on supporting multidescriptor wallets.
af5dd7c to
8d5d881
Compare
Member
|
FYI the CI issue is probably the same one @vladimirfomene ran into yesterday on his PR. I should be able to get a PR in today to fix it. |
8d5d881 to
3d94a8a
Compare
- Specify which version of zip needs to be updated - Pin rustls - Pin flate2
3d94a8a to
dcc4636
Compare
Member
Author
|
Now it should be fine :) |
30 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing