Skip to content

Avoid pinning dependencies, use --precise in ci#1046

Merged
danielabrozzoni merged 2 commits intobitcoindevkit:masterfrom
danielabrozzoni:fix_msrv
Jul 25, 2023
Merged

Avoid pinning dependencies, use --precise in ci#1046
danielabrozzoni merged 2 commits intobitcoindevkit:masterfrom
danielabrozzoni:fix_msrv

Conversation

@danielabrozzoni
Copy link
Copy Markdown
Member

@danielabrozzoni danielabrozzoni commented Jul 24, 2023

Fixes #1035

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@danielabrozzoni danielabrozzoni force-pushed the fix_msrv branch 2 times, most recently from 785ff8a to 8c7ed11 Compare July 24, 2023 14:17
@danielabrozzoni danielabrozzoni mentioned this pull request Jul 24, 2023
Closed
adoerr
adoerr reviewed Jul 24, 2023
View reviewed changes
@notmandatory
Copy link
Copy Markdown
Member

notmandatory commented Jul 25, 2023

LGTM. One thing to add is a short MSRV section in bdk/README.md similar to what the rust-bitcoin project did (https://github.com/rust-bitcoin/rust-bitcoin/blob/master/README.md#minimum-supported-rust-version-msrv). For example:

Minimum Supported Rust Version (MSRV)

This library should compile with any combination of features with Rust 1.57.0.

To build with the MSRV you will need to pin dependencies as follows:

# log 0.4.19 has MSRV 1.60.0+
cargo update -p log --precise "0.4.18"
# tempfile 3.7.0 has MSRV 1.63.0
cargo update -p tempfile --precise "3.6.0"

notmandatory
notmandatory reviewed Jul 25, 2023
View reviewed changes
@danielabrozzoni danielabrozzoni force-pushed the fix_msrv branch 4 times, most recently from 711e48e to a3317b2 Compare July 25, 2023 11:22
@danielabrozzoni
ci: No need to add the llvm repository for wasm
56b8eea 
Adding it fails with "The repository'http://apt.llvm.org/focal
llvm-toolchain-focal Release' does not have a Release file.", and for
some reason it's not needed anymore.
@danielabrozzoni
ci: Avoid pinning dependencies, use --precise
ffb7c79 
Fixes bitcoindevkit#1035
@danielabrozzoni
Copy link
Copy Markdown
Member Author

danielabrozzoni commented Jul 25, 2023

Thanks! Fixed all your comments, and added a fix for the wasm build.

adoerr
adoerr approved these changes Jul 25, 2023
View reviewed changes
Copy link
Copy Markdown

@adoerr adoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

evanlinjin
evanlinjin approved these changes Jul 25, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ffb7c79

@danielabrozzoni danielabrozzoni merged commit 8f38e96 into bitcoindevkit:master Jul 25, 2023
@danielabrozzoni danielabrozzoni mentioned this pull request Jul 25, 2023
Closed
@notmandatory notmandatory added this to the 1.0.0-alpha.2 milestone Jul 25, 2023
@evanlinjin evanlinjin mentioned this pull request Aug 2, 2023
Merged
3 tasks
@notmandatory notmandatory mentioned this pull request Aug 8, 2023
Closed
8 tasks
@danielabrozzoni danielabrozzoni deleted the fix_msrv branch October 11, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@notmandatory notmandatory notmandatory left review comments

@evanlinjin evanlinjin evanlinjin approved these changes

+1 more reviewer

@adoerr adoerr adoerr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@danielabrozzoni danielabrozzoni

Labels

None yet

Projects

BDK Wallet
Archived in project

Milestone

1.0.0-alpha.2

Development

Successfully merging this pull request may close these issues.

Log dependency fix makes use as library very hard

4 participants

@danielabrozzoni @notmandatory @adoerr @evanlinjin