Improve seed generation script for clarity #7398
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The overall goal here is to make it a bit more clear what criteria go into selecting seeds, but is really just "general clean-up".
Stuff in this (somewhat large) change
Entry= a line in the file,Address= that first field)main,get_entries_limited_by_asn) which shaves off some time (40s -> 20s for me)get_address_type,get_asn).Entry.is_valid()).setfor uniquely selecting addresses (where port is ignored).mainmethod.Stuff that might be worth doing
I assume this script is run only once in a blue moon, so I get it if you want to punt on taking a look. In the meantime I can always add tests to make everyone more confident that I didn't just bork the deployment process for bitcoin-core :p