Skip to content

Conversation

@ChainQuery
Copy link

Argument 5, subtractfeefromamount, listed in help for sendmany is ignored and not a valid argument.

Remove it from help.

Argument 5, subtractfeefromamount, listed in help for sendmany is ignored and not a valid argument.

Remove it from help.
@ChainQuery ChainQuery changed the title RPC SendMany Help: remove #5 subtractfeefromamount RPC SendMany Help: remove subtractfeefromamount Jul 31, 2015
@casey
Copy link
Contributor

casey commented Jul 31, 2015

I'm not sure if I'm reading the code correctly, but it looks like the argument is not ignored. The array is stored in subtractFeeFromAmount on line 969, and then used to create the CRecipient on line 999, which is eventually passed into pwalletMain->CreateTransaction.

@ChainQuery
Copy link
Author

I'm not sure if I'm reading it correctly either, but this was inspired by /contrib/bitrpc/bitrpc.py sendmany inputs starting on line 251. The 5th, subtractfeefromamount, is ignored.

@casey
Copy link
Contributor

casey commented Jul 31, 2015

It looks like bitrpc.py is just missing the subtractfeefromamount argument. This is an omission in bitrpc.py, not a bug in the help dialog.

@ChainQuery
Copy link
Author

Your right. Closing this request.

@ChainQuery ChainQuery closed this Jul 31, 2015
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants