guix: introduce --exclude parameter to guix-clean#34790
guix: introduce --exclude parameter to guix-clean#34790kevkevinpal wants to merge 1 commit intobitcoin:masterfrom
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process. ConflictsNo conflicts as of last run. |
|
Concept ~0. Not sure how much further we need to complicate this script.
Can you fix the PR description. |
|
I'm not sure about this change either. Listing the files as done now seems good enough to me, and the changes proposed here mostly seem to complicate things. |
967b498 to
3250c42
Compare
3250c42 to
b752f12
Compare
|
Thank you for the review!
Part of the reason I thought this might make sense and not add too much complication is that
Fixed!
Understood, if others feel this is unneeded, I can close. I do feel this adds useful functionality for this script, so users don't have to manually remove files if they don't want one deleted. |
Summary
This is motivated by #34776 (comment) and a follow-up to #34776.
The motivation is that when a user runs
contrib/guix/guix-cleanit will clean the whole directory or nothing leading the user to have to manually clear out these files. It would be useful to be able to exclude certain files.It adds the
--excludeand--help/-hparameters tocontrib/guix/guix-cleanRight now, when a user runs that script, it will delete everything. It makes sense to allow the user to exclude any files or directories from being removed.
Help text
Multiple excludes
Unknown option
Exclude with --force