Skip to content

Bump default -dbcache to 1GiB#34763

Closed
darosior wants to merge 4 commits intobitcoin:masterfrom
andrewtoth:bump_dbcache2
Closed

Bump default -dbcache to 1GiB#34763
darosior wants to merge 4 commits intobitcoin:masterfrom
andrewtoth:bump_dbcache2

Conversation

@darosior
Copy link
Member

@darosior darosior commented Mar 6, 2026

This is an alternative to #34692 that does not introduce detection of system resources.

@DrahtBot
Copy link
Contributor

DrahtBot commented Mar 6, 2026

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK andrewtoth

If your review is incorrectly listed, please copy-paste <!--meta-tag:bot-skip--> into the comment that the bot should ignore.

LLM Linter (✨ experimental)

Possible typos and grammar issues:

  • "the UTXO database cache size, this defaults to 1024." -> "the UTXO database cache size. It defaults to 1024." [Comma splice creates a run-on sentence; splitting into two sentences improves clarity.]

  • "The unit is MiB (1024)." -> "The unit is MiB (1024 MiB) or clarify as MiB (1024^2 bytes)" ["(1024)" is ambiguous/unclear—it doesn't state the unit or whether it means 1024 MiB or 1024^2 bytes; clarify the intended meaning.]

2026-03-06 20:03:22

@darosior darosior mentioned this pull request Mar 6, 2026
@andrewtoth
Copy link
Contributor

ACK 153c7ff

Either PR is fine with me.

@darosior
Copy link
Member Author

darosior commented Mar 6, 2026

Looks like the power that be made a decision! Closing this then.

@darosior darosior closed this Mar 6, 2026
@l0rinc
Copy link
Contributor

l0rinc commented Mar 6, 2026

post-close NACK - as discussed before, low-end machines can't run with that much default - see #31645 and #34641 for details.

@darosior
Copy link
Member Author

darosior commented Mar 6, 2026

It is not a realistic expectation for a default to cover every single system the software can be ran on, this is the reason configuration options exist in the first place. Default values should be set for the vast majority of targeted systems.

@l0rinc
Copy link
Contributor

l0rinc commented Mar 6, 2026

It is not a realistic expectation for a default to cover every single system the software can be ran on

Maybe, "every single" is a high bar, but we can probably calculate a good default for most, see #34641

@yancyribbens
Copy link
Contributor

Looks like the power that be made a decision! Closing this then.

Shakes fist the powers that be, after all, isnt that why why people are into decentralized and privacy focused projects..

Anyway, I realize people are just trying to ship something, however I feel like maybe closing this PR was a bit premature, after all, there is another release after this one.. Personally this is more what I had in mind, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants