[30.x] Partial backport #34650#34754
Conversation
The `find_package(Qt .. MODULE REQUIRED COMPONENTS ...)` call must treat any missing component as a fatal error. Github-Pull: bitcoin#34650 Rebased-From: c555845
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please copy-paste |
|
Looking into an error when cross-compiling for ARM32... |
Backported from: qt/qtbase@7fccc79 Github-Pull: bitcoin#34650 Rebased-From: d7e972a
Meta-Issue: https://qt-project.atlassian.net/browse/QTBUG-143470 Backports: qt/qtbase@679e8bd qt/qtbase@3312e89 qt/qtbase@05f201a An additional includes fix is needed after the others: qt/qtbase@d68fc6e Github-Pull: bitcoin#34650 Rebased-From: 3cb4d60
Github-Pull: bitcoin#34650 Rebased-From: 473e5f8
ef15c61 to
fbfc778
Compare
|
Undrafted. |
|
ACK fbfc778 |
|
utACK fbfc778
Makes sense to drop this QT bump but take the fixes on a stable branch. Rest of the backports look correct, mainly differing on patch metadata. It is missing a release note, is that intentional as it's "partial"? |
I think we can add a partial release note in #34689. |
This PR backports commits from #34650 not related to Qt update. They fix issues when building with GCC 16 and improves Qt detecting.